-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#876 Major contribution to gnucash-android #882
base: develop
Are you sure you want to change the base?
Conversation
…ute Split Balance
…dows. isChecked() : true == CREDIT. CREDIT => red, DEBIT => green
…alance (and not more debit/credit)
…Listener to TransactionTypeSwitch
…o colorize in red/green
…olorize in red/green
…ht, like for transaction without splits
…o getAmountColor()
… computed at the date indicated below
…from AccountType
…ke methods non static
…nsure storing of absolute values in splits
…itch is visible
…able to change Book
Thank you for your contribution, @JeanGarf. I immediately thought about writing to @codinguser about your PR, have you tried getting in touch with him, possibly by email or other means? We can't let this solid amount of work be stuck in limbo. |
Hi strixaluco, Yes I tried to send email to @codinguser, but I didn't get any response. I'm new to contribute to open source project and to Android and therefore I don't know what to do. I can perhaps upload the apk corresponding to my cumulative tw_develop branch, but I don't if it is a good idea or not ? |
It's a pity there was no response. I've also replied on his tweet about GnuCash from about 3 years ago, mentioning stalled PRs, but who knows if that will have any effect. |
Seems that another contributor managed to reach @codinguser and he promised to look into merging all the PRs. |
Hi @strixaluco I added a page on my web site to allow downloading of the apk with all my contributions If you're interested to test or use it, tell me if it works fine. See you |
Really appreciate your efforts, @JeanGarf. Will try your build and will report if anything. |
The enhancements are pretty useful!
|
I Thumas, I'm sorry, I'm very new to android dev and I didn't success to run UI tests. Could you explain me how to make them work ? Thanks |
Could you please re-upload the apk? The link from Google Drive isn't working. |
Hi, I'm sorry, I made a small change in the app and forget to update my link. Could you try again and tell me if it works fine ? See you P.S. : The change is in the Account chooser is the following : When you type characters in the search field, account list is filtered. If only one account remains in the filtered list, it is not automatically selected anymore. You have to click on it to choose it. |
Version available in provided link have one issue to me. |
I've got the same issue: it rounds the values. If I put $1.98, it rounds to $2.
…On Fri, May 28, 2021, 06:16 albert2004 ***@***.***> wrote:
Version available in provided link have one issue to me.
When I use my currency (PLN) and provide amount in transaction, for
example 130,67PLN it works fine.
But when I enter transaction again for edit, amount is rounded (131PLN).
This was not happening with official version.
I write it here, since I don't see "issues" section in your fork - maybe
disabled on purpose ;)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#882 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUBJL5J465IRGV3MGKQUUQLTP5NPXANCNFSM4OCZXQ7A>
.
|
Hi, thank for reporting this issue. See you |
…not currency symbol because it shall be evaluated (in order to allows arithmetic expressions as value)
Hi albert2004 and aramaicus, I've corrected my mistake. You can get the corrected apk on my web site here : http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/ Thanks for having reported the issue. Bye |
Hi JeanGarf. I've already downloaded. I'll test it and report you any issue.
I'm glad to help.
Thank you for keeping Gnucash for Android alive.
…On Thu, Jun 10, 2021, 17:18 JeanGarf ***@***.***> wrote:
Version available in provided link have one issue to me.
When I use my currency (PLN) and provide amount in transaction, for
example 130,67PLN it works fine.
But when I enter transaction again for edit, amount is rounded (131PLN).
This was not happening with official version.
I write it here, since I don't see "issues" section in your fork - maybe
disabled on purpose ;)
Hi albert2004 and aramaicus,
I've corrected my mistake. You can get the corrected apk on my web site
here :
http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/
Thanks for having reported the issue.
Bye
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#882 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUBJL5NUZQKIX5RBN6ZPAJLTSEMYVANCNFSM4OCZXQ7A>
.
|
Hi JeanGarf, |
Unfortunately Gnucash-dev crashes a lot more than the Playstore version. At
least in my phone Moto G100 Android 11 64 bits.
It crashes a lot but doesn't let me crash report it.
I am not a dev so I am not sure what is the matter here.
…On Thu, Jun 10, 2021, 17:24 albert2004 ***@***.***> wrote:
Hi JeanGarf,
I built from sources with fix.
Also I corrected one language typo.
For Android banking I do not except anything more. Finally it works like
it should.
Good luck with push!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#882 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUBJL5P4236UBMJ356H53HLTSENQFANCNFSM4OCZXQ7A>
.
|
I have and file created on Gnucash on Android 2 years ago. That file works with Gnucash desktop but doesn't work with Gnucash for Android. When I try to open it, I receive that message: "An error occurred while importing the GnuCash accounts Unable to parse transaction time - 2019-03-31 15:00:13" I'm using GnucashAndroid_v2.4.1-dev4_535f3d53.apk I don't mind sharing that file. There is no confidential information in it. If you care about it, make me know so I'll send you the file. |
Hi,
This is one of my main contribution to GnucashAndroid.
It corrects #876, but also lots of other errors like
...
You can see all my contributions together on the following branch :
https://github.com/JeanGarf/gnucash-android/tree/tw_develop
If you want to get the corresponding apk, you can get it on my web site :
http://thierryw777.free.fr/index.php/bureautique/comptabilite/gnucash-android/
See you,